Merge from fnal/v0.22.0-fermi #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Harmen Stoppels <[email protected]>
* update prod-util recipe * [@spackbot] updating style on behalf of AlexanderRichert-NOAA
* grads: fix libpng and g2c deps * Update package.py * [@spackbot] updating style on behalf of AlexanderRichert-NOAA
* variorum: add branch dev and version 0.8.0 * formatting
* Update FFCx and UFCx to v0.8 * Syntax fix
* minimap2: adding version 2.28 * minimap2: adding maintainer --------- Signed-off-by: Shane Nehring <[email protected]>
We recently switched to using the new ReadTheDocs with "addons". That includes its own analytics, which is nice, but we also want to continue using our GA4 analytics. Adding GA4 is no longer supported by RTD, so we have to add it manually. - [x] re-add the gtag to all pages, manually Signed-off-by: Todd Gamblin <[email protected]>
Fix a bug triggered by missing a virtual on some transitive edge, in a subdag of a pure build dependency.
* Add rosco package * format * remove unused * Add in other versions * start adding some patches * finish adding the patches
* py-tensorflow: fix aarch64 build * [@spackbot] updating style on behalf of aweits * patch format * change patch strategy, actually get the logic correct in the patch * only patch 2.16.1 onwards for aarch64 * __CUDACC__ not __NVCC__ * !(defined(__NVCC__) && defined(__CUDACC__)) --------- Co-authored-by: aweits <[email protected]>
* [TAU package] Update with +rocprofv2. Updated some tests. pdated with +rocprofv2 flag. Only works with rocm-core >= 6.0.0 Can be tested with (Omnia): spack install tau@master +rocm+rocprofv2 %gcc@11 Needs the last commit in our local repository, can be done by modifying the "git = " line, or waiting until the public one is updated. In the case that tests cause issues when building TAU, there is the flag: disable_tests = False The rocm test is disabled by default, as the PR regarding tests loading dependencies is not solved (PR#43682). * [@spackbot] updating style on behalf of jordialcaraz --------- Co-authored-by: jordialcaraz <[email protected]>
* updating vacuumms for new release * formatting * re-order versions and remove triple quote
* WIP NWChem with ARMCI-MPI and TCE optional
* rename armci-mpi to armcimpi
* add version for git
* add ARMCI-MPI support to NWChem package
EXTERNAL_ARMCI_PATH needs to be set to the ARMCI-MPI package install prefix.
I could not get it from spec["armcimpi"] but it worked to use the dependent build environment method to export a generic environmental variable to use instead.
* i suppose i can maintain NWChem as well
* check rejects option that dozens of packages use
i do not have time to fight with this nonsense
Run . share/spack/setup-env.sh
==> Error: armcimpi version 'master' has extra arguments: 'branch'
Valid arguments for a url fetcher are:
'url', 'sha256', 'md5', 'sha1', 'sha224', 'sha384', 'sha512', and 'checksum'
Error: Process completed with exit code 1.
* style
* ARMCI-MPI needs depends_on; the rest seems fixed
* fix ARMCI selection per review feedback from @zzzoom
spack#43883 (comment)
* address reviewer feedback from @yizeyi18
spack#43883 (comment)
elaborate on what +extratce does, in terms of the NWChem build environment variables,
some of which are documented on https://nwchemgit.github.io/TCE.html.
* style
* Update var/spack/repos/builtin/packages/nwchem/package.py
---------
Signed-off-by: Jeff Hammond <[email protected]>
Co-authored-by: Carlos Bederián <[email protected]>
* Add -fPIC to hdf-eos2 builds * Use self.compiler.cc_pic_flag instead of -fPIC * Fix style in var/spack/repos/builtin/packages/hdf-eos2/package.py
Since reuse is the default now, `--reuse-deps` can be confusing, as it technically does not imply roots are fresh. So add `--fresh-roots`, which is also easier to discover when running `spack concretize --fre<tab>`
Signed-off-by: Shane Nehring <[email protected]>
Co-authored-by: Owen Solberg <[email protected]>
Currently SPACK_COLOR=always is not respected in the build process on macOS, because the global `_force_color` is re-evaluated in global scope during module setup, where it is always `None`. So, move global init bits from main.py to the module itself.
Add the ability to include any number of (potentially nested) concrete environments, e.g.:
```yaml
spack:
specs: []
concretizer:
unify: true
include_concrete:
- /path/to/environment1
- /path/to/environment2
```
or, from the CLI:
```console
$ spack env create myenv
$ spack -e myenv add python
$ spack -e myenv concretize
$ spack env create --include-concrete myenv included_env
```
The contents of included concrete environments' spack.lock files are
included in the environment's lock file at creation time. Any changes
to included concrete environments are only reflected after the environment
is re-concretized from the re-concretized included environments.
- [x] Concretize included envs
- [x] Save concrete specs in memory by hash
- [x] Add included envs to combined env's lock file
- [x] Add test
- [x] Update documentation
Co-authored-by: Kayla Butler <<[email protected]>
Co-authored-by: Tamara Dahlgren <[email protected]
m>
Co-authored-by: Todd Gamblin <[email protected]>
Signed-off-by: Todd Gamblin <[email protected]>
Signed-off-by: Todd Gamblin <[email protected]>
GCC C++ headers like cstdlib use `#include_next <stdlib.h>` to wrap libc headers. We're using `-isystem` for libc, which puts those headers too early in the search path. `-idirafter` fixes this so `include_next` works.
macos-latest switched to macos-14, so now we are running two identical jobs.
When an include filter on externals is present, implicitly include libcs. Also, do not penalize deprecated versions if they come from externals.
Apparently urllib can throw a range of different exceptions: 1. HTTPError 2. URLError with e.reason set to the actual exception 3. TimeoutError from getresponse, which is not wrapped
These changes were added to the release branch but did not make it onto `develop`.
knoepfel
approved these changes
May 14, 2024
gartung
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
armci(Add a default provider forarmcispack/spack#43997)spack env create <env>: dir if dir-like (spack env create <env>: dir if dir-like spack/spack#44024)include_concrete(Include concrete environments withinclude_concretespack/spack#33768)[email protected]:4.3.3(r: patch R-CVE-2024-27322 for[email protected]:4.3.3spack/spack#44050)juliaandvim(gitlab ci: tutorial: addjuliaandvimspack/spack#44073)