Fix some value tracking mistakes

src/Clause/Conditional.php

@@ -47,7 +47,8 @@ public function getValues(): array
             if ($values[$i] instanceof QueryInterface) {
                 $value = $values[$i]->getValues();
                 array_splice($values, $i, 1, $value);
-                $i += count($value);
+                $i += count($value) - 1;
+                $count += count($value) - 1;
             }
         }
 

src/Clause/Join.php

@@ -38,6 +38,17 @@ public function __construct($subject, ConditionalInterface $on, string $type = '
      */
     public function getValues(): array
     {
+        if (is_array($this->subject)) {
+            reset($this->subject);
+            $alias = key($this->subject);
+            if (!is_string($alias)) {
+                trigger_error('Invalid subject array, use string keys for alias', E_USER_ERROR);
+            }
+            $table = $this->subject[$alias];
+            if ($table instanceof SelectInterface) {
+                return array_merge($table->getValues(), $this->on->getValues());
+            }
+        }
         return $this->on->getValues();
     }
 

src/Statement/Delete.php

@@ -77,10 +77,6 @@ public function getValues(): array
             $values = array_merge($values, $this->where->getValues());
         }
 
-        if (!empty($this->orderBy)) {
-            $values = array_merge($values, $this->orderBy);
-        }
-
         if ($this->limit != null) {
             $values = array_merge($values, $this->limit->getValues());
         }

tests/Clause/ConditionalTest.php

@@ -75,6 +75,7 @@ public function testGetValues()
 
         $this->assertIsArray($subject->getValues());
         $this->assertCount(1, $subject->getValues());
+        $this->assertEquals($subject->getValues(), ['val']);
     }
 
     public function testGetValuesWithQuery()
@@ -92,5 +93,15 @@ public function testGetValuesWithQueryAndArgs()
 
         $this->assertIsArray($subject->getValues());
         $this->assertCount(2, $subject->getValues());
+        $this->assertEquals($subject->getValues(), [1, 2]);
+    }
+
+    public function testGetValuesWithMultipleValues()
+    {
+        $subject = new Conditional('col', 'BETWEEN', [new Method('test', 1, 2), new Method('test', 3, 4)]);
+
+        $this->assertIsArray($subject->getValues());
+        $this->assertCount(4, $subject->getValues());
+        $this->assertEquals($subject->getValues(), [1, 2, 3, 4]);
     }
 }

tests/Clause/JoinTest.php

@@ -107,4 +107,21 @@ public function testGetValues()
         $this->assertIsArray($subject->getValues());
         $this->assertCount(1, $subject->getValues());
     }
+
+    public function testGetValuesWithSubselect()
+    {
+        $db = $this->createMock(Database::class);
+        $subject = new Join(
+            ['alias' => (new Select($db))->from('table')->where(new Conditional('column1', '=', 'value1'))],
+            new Conditional('column2', '=', 'value2')
+        );
+
+        $this->assertStringMatchesFormat(
+            'JOIN (SELECT * FROM table WHERE column1 = ?) AS alias ON column2 = ?',
+            $subject->__toString()
+        );
+        $this->assertIsArray($subject->getValues());
+        $this->assertCount(2, $subject->getValues());
+        $this->assertEquals(['value1', 'value2'], $subject->getValues());
+    }
 }

tests/Statement/DeleteTest.php

@@ -162,9 +162,8 @@ public function testGetValuesWithOrderBy()
             ->orderBy('id', 'ASC')
             ->orderBy('name', 'DESC');
 
-        // FIXME This seems broken...
         $this->assertIsArray($this->subject->getValues());
-        $this->assertCount(2, $this->subject->getValues());
+        $this->assertCount(0, $this->subject->getValues());
     }
 
     public function testGetValuesWithLimit()

tests/Statement/UpdateTest.php

@@ -242,7 +242,6 @@ public function testGetValuesWithOrderBy()
             ->orderBy('id', 'ASC')
             ->orderBy('name', 'DESC');
 
-        // FIXME This seems broken...
         $this->assertIsArray($this->subject->getValues());
         $this->assertCount(1, $this->subject->getValues());
     }