Fix FabricTransformer for Minecraft classic and pre-classic #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceWalkerRS
force-pushed
the
fabric-transformer
branch
from
e063877 to
a867a1c
Compare
|
Do we need the env stripping and access transformation for these versions? The former only makes sense if there is a separate dedicated server jar and the latter depends on whether the production jar has mapping dependent access issues. |
|
The access transformations are needed for sure. In old versions the main class moved between packages a few times and if you want to keep the intermediary consistent you need to fix package access errors. An argument could be made that the env stripping applies to classic (given it has dedicated servers) though we'd first have to confirm the client and server for these versions can be merged at all. |
|
I turned it into a more generic property, please have a look at #1056 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isMinecraftClasscheck does not consider classes in thecom.mojang.rubydungpackage (pre-classic) or thecom.mojang.minecraftpackage (classic). This PR adds those checks.