allow constructors as method reference entrypoints - #982
Open
rhysdh540 wants to merge 2 commits into
Open
Conversation
Member
|
Whats the benefit of this? Just becuase forge does it doesn't mean its a good idea. |
|
He wants to make Zume smaller by merging the entrypoint classes for Forge and Fabric. |
Author
|
that wasn't my initial motivation for making this pull request; constructors not working was something I noticed a while ago. I realized the potential size benefits of it later. as for why I opened this, I'm not really sure, I just thought it would be cool to have as a feature. do you have any other reasons/potential unwanted behavior that this could cause that would make it a bad idea? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now you can pretend to be forge by making your entrypoint
your.package.YourClass::<init>!not exactly the cleanest implementation ever but it seems to work on the test mod