Skip to content

Conversation

@clainyun
Copy link
Member

@clainyun clainyun commented May 23, 2025

๐Ÿ“Œ PR ์ œ๋ชฉ

feat | sprint2 | ํ†ตํ•ฉ | ์ž‘์—…์ž ๊ด€๋ฆฌ ๊ธฐ๋Šฅ ๊ตฌํ˜„ (์ž‘์—…์ž ์ƒ์„ฑ, ์œ„์น˜ ์ถ”์ , ๊ณต๊ฐ„ ๋‹ด๋‹น์ž ์ง€์ •) | ์œค๋‹ค์ธ


โœจ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

1. ์ž‘์—…์ž ์ƒ์„ฑ ๊ธฐ๋Šฅ

  • ์ž‘์—…์ž ์ •๋ณด(ID, ์ด๋ฆ„, ์ „ํ™”๋ฒˆํ˜ธ, ์ด๋ฉ”์ผ) ๋“ฑ๋ก ๊ธฐ๋Šฅ ๊ตฌํ˜„
  • ์ž‘์—…์ž๋ณ„ ์ถœ์ž… ๊ฐ€๋Šฅ ๊ณต๊ฐ„ ์„ค์ • ๊ธฐ๋Šฅ ๊ตฌํ˜„ (worker_zone ํ…Œ์ด๋ธ” ๋งคํ•‘)
  • POST /api/workers ์—”๋“œํฌ์ธํŠธ ๊ตฌํ˜„

2. ์ž‘์—…์ž ์œ„์น˜ ์ถ”์  ์‹œ์Šคํ…œ

  • ์›จ์–ด๋Ÿฌ๋ธ” ๊ธฐ๊ธฐ๋กœ๋ถ€ํ„ฐ ์‹ค์‹œ๊ฐ„ ์œ„์น˜ ๋ฐ์ดํ„ฐ ์ˆ˜์‹ ์„ ์œ„ํ•œ REST API ๊ตฌํ˜„
  • POST /api/worker-locations/update ์—”๋“œํฌ์ธํŠธ ๊ตฌํ˜„
  • zone_hist ํ…Œ์ด๋ธ”์„ ํ†ตํ•œ ์ž‘์—…์ž ์œ„์น˜ ์ด๋ ฅ ๊ด€๋ฆฌ ์‹œ์Šคํ…œ ๊ตฌํ˜„
  • ์ž‘์—…์ž์˜ ํ˜„์žฌ ์œ„์น˜ ์กฐํšŒ ๊ธฐ๋Šฅ ๊ตฌํ˜„

3. ๊ณต๊ฐ„ ๋‹ด๋‹น์ž ๊ด€๋ฆฌ ๊ธฐ๋Šฅ

  • ๊ณต๊ฐ„๋ณ„ ๋‹ด๋‹น์ž ์ง€์ •/ํ•ด์ œ ๊ธฐ๋Šฅ ๊ตฌํ˜„
  • ๋‹ด๋‹น์ž ํ›„๋ณด ๋ชฉ๋ก ์กฐํšŒ ๊ธฐ๋Šฅ ๊ตฌํ˜„
  • ํ˜„์žฌ ๋‹ด๋‹น์ž ์ •๋ณด ์กฐํšŒ ๊ธฐ๋Šฅ ๊ตฌํ˜„
  • WorkerManagerService ๊ตฌํ˜„์œผ๋กœ ๋‹ด๋‹น์ž ๊ด€๋ จ ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง ๋ถ„๋ฆฌ

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ฝ”๋“œ์— ๋ถˆํ•„์š”ํ•œ ๋ถ€๋ถ„์€ ์—†๋Š”๊ฐ€?
    • ๋ฏธ์‚ฌ์šฉ ์ฝ”๋“œ ์ œ๊ฑฐ ๋ฐ ์ฃผ์„ ์ •๋ฆฌ ์™„๋ฃŒ
    • ์ค‘๋ณต ๋กœ์ง ์„œ๋น„์Šค ๊ณ„์ธต์œผ๋กœ ๋ถ„๋ฆฌ ์™„๋ฃŒ
  • ๊ธฐ๋Šฅ์ด ์ •์ƒ ๋™์ž‘ํ•˜๋Š”๊ฐ€?
    • Swagger UI๋ฅผ ํ†ตํ•œ API ํ…Œ์ŠคํŠธ ์™„๋ฃŒ
    • ์›จ์–ด๋Ÿฌ๋ธ” ๊ธฐ๊ธฐ ์—ฐ๋™ ํ…Œ์ŠคํŠธ ์™„๋ฃŒ
    • ๊ณต๊ฐ„ ๋‹ด๋‹น์ž ์ง€์ •/ํ•ด์ œ ๊ธฐ๋Šฅ ํ…Œ์ŠคํŠธ ์™„๋ฃŒ
  • ์˜์กด์„ฑ์€ ๋ฌธ์ œ๊ฐ€ ์—†๋Š”๊ฐ€?
    • JPA, Spring Web ์˜์กด์„ฑ ์ •์ƒ ๋™์ž‘ ํ™•์ธ
    • ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค ์Šคํ‚ค๋งˆ ๋ณ€๊ฒฝ์‚ฌํ•ญ Flyway migration์œผ๋กœ ๊ด€๋ฆฌ
  • ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€๋Š” ๋ช…ํ™•ํ•œ๊ฐ€?
    • ๊ธฐ๋Šฅ๋ณ„๋กœ ์ปค๋ฐ‹ ๋ถ„๋ฆฌํ•˜์—ฌ ์ด๋ ฅ ๊ด€๋ฆฌ
    • ๊ฐ ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€์— ๋ณ€๊ฒฝ ๋‚ด์šฉ ์ƒ์„ธ ๊ธฐ์ˆ 

๐Ÿ“Ž ๊ด€๋ จ ์ด์Šˆ


๐Ÿ’ฌ ์ถ”๊ฐ€ ์„ค๋ช…

๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค ๋ณ€๊ฒฝ์‚ฌํ•ญ

  1. worker_zone ํ…Œ์ด๋ธ”

    • ์ž‘์—…์ž-๊ณต๊ฐ„ ๋งคํ•‘ ์ •๋ณด ์ €์žฅ
    • ๋‹ด๋‹น์ž ์—ฌ๋ถ€(manage_yn) ์ปฌ๋Ÿผ์œผ๋กœ ๊ณต๊ฐ„ ๋‹ด๋‹น์ž ๊ด€๋ฆฌ
  2. zone_hist ํ…Œ์ด๋ธ”

    • ์ž‘์—…์ž์˜ ์œ„์น˜ ์ด๋ ฅ ๊ด€๋ฆฌ
    • exist_flag๋กœ ํ˜„์žฌ ์œ„์น˜ ํ‘œ์‹œ (1: ํ˜„์žฌ ์œ„์น˜, 0: ์ด์ „ ์œ„์น˜)

API ์‘๋‹ต ๊ตฌ์กฐ

  • ์ž‘์—…์ž ์ƒ์„ฑ: 200 OK (์„ฑ๊ณต), 400 Bad Request (์ž˜๋ชป๋œ ์š”์ฒญ)
  • ์œ„์น˜ ์—…๋ฐ์ดํŠธ: 200 OK (์„ฑ๊ณต), 404 Not Found (์ž‘์—…์ž/๊ณต๊ฐ„ ์—†์Œ)
  • ๋‹ด๋‹น์ž ์ง€์ •: 200 OK (์„ฑ๊ณต), 400 Bad Request (๊ถŒํ•œ ์—†์Œ)

WorkerServiceTest ์—์„œ ๋ฐœ์ƒํ•˜๋Š” NullPointerException ์˜ค๋ฅ˜ ํ•ด๊ฒฐ

clainyun added 6 commits May 22, 2025 01:33
@clainyun clainyun requested a review from chsubinn May 23, 2025 01:17
@clainyun clainyun self-assigned this May 23, 2025
@clainyun clainyun merged commit 26b6d25 into develop May 23, 2025
1 check passed
wdd1016 added a commit that referenced this pull request May 23, 2025
Revert #44 (๐Ÿ“Œ PR ์ œ๋ชฉ feat | sprint2 | ํ†ตํ•ฉ | ์ž‘์—…์ž ๊ด€๋ฆฌ ๊ธฐ๋Šฅ ๊ตฌํ˜„)
gwangbu-desu pushed a commit that referenced this pull request May 24, 2025
## ๐Ÿ“Œ PR ์ œ๋ชฉ feat | sprint2 | ํ†ตํ•ฉ | ์ž‘์—…์ž ๊ด€๋ฆฌ ๊ธฐ๋Šฅ ๊ตฌํ˜„ (์ž‘์—…์ž ์ƒ์„ฑ, ์œ„์น˜ ์ถ”์ , ๊ณต๊ฐ„ ๋‹ด๋‹น์ž ์ง€์ •) | ์œค๋‹ค์ธ
gwangbu-desu pushed a commit that referenced this pull request May 24, 2025
Revert #44 (๐Ÿ“Œ PR ์ œ๋ชฉ feat | sprint2 | ํ†ตํ•ฉ | ์ž‘์—…์ž ๊ด€๋ฆฌ ๊ธฐ๋Šฅ ๊ตฌํ˜„)
@wdd1016 wdd1016 deleted the feature/FRB-140 branch June 3, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants