Skip to content

Conversation

@chsubinn
Copy link
Contributor

@chsubinn chsubinn commented May 23, 2025

📌 PR 제목

chore: 코드 리팩토링


✨ 변경 사항

  • 디렉토리 구조를 도메인형으로 대폭 변경하였습니다.
    • domain: 도메인별 service, repository 등의 컴포넌트
    • global: 프로젝트 전반에 필요한 유틸리티 등
    • messaging: MQTT, Kafka 등 메시징에 필요한 코드 (리팩토링 진행 x)
  • 공통 응답 로직을 추가하였습니다. 따라서 controller에서 반환 시 DTO만 반환해도 됩니다.
  • DTO명을 request와 response로 분리하여 수정하였습니다.
  • service <-> service로 참조하는 부분을 service -> repository로 참조하도록 변경하였습니다.

📸 스크린샷 (선택)

변경 전 변경 후
(이미지) (이미지)

📎 관련 이슈


💬 추가 설명

  • 리뷰어가 참고하면 좋을 내용이 있다면 적어주세요.

@chsubinn chsubinn self-assigned this May 23, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Check Plz]
@operation, @tag 어노테이션으로 Swagger 문서화
✅ ResponseEntity로 상태 코드 명확히 반환

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Check Plz]
✅ 각 메서드별 //한글 주석 필요 : 되어있는 부분 있고 안되어 있는 부분 있음
✅ 메인 클래스 JavaDoc 주석필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Check Plz]
✅ 각 메서드별 //한글 주석 필요 : 되어있는 부분 있고 안되어 있는 부분 있음, 주석 위치 메서드 위에
✅ 메인 클래스 JavaDoc 주석필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Check Plz]
@Schema 어노테이션 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 비즈니스 로직서비스랑 repo서비스랑 분리 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo
메서드별 주석(한글 주석) , 클래스 주석 (javaDoc) 확인 해주세요 ~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcema 어노테이션 확인해주세요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcema 어노테이션 확인해주세요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcema 어노테이션 확인해주세요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcema 어노테이션 확인해주세요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo
우영 확인 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToDo (다인 확인필요)

  • 주석 달아주세요
  • 비즈니스로직, repo 서비스로 분리해주세요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 주석 달아주세요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToDo

  • @Schema 어노테이션 확인해주세요
  • fromentity, toentity 둘다 만들어주세요~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • @shema 어노테이션 필요
  • fromEntity, toEntity 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Copy link
Contributor

@JuneSHYoo JuneSHYoo May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 담당자 찾아서 비즈니스 로직용, repo용 서비스 분리 필요
  • 주석 확인해주세요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • Jooseok plz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • JavaDoc 주석 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 주석 다시 살려주세요~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 주석 살려주세요~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 주석 오네가시마스

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 담당자 찾아서 주석, 비즈니스로직용 repo용 서비스 분리 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 담당자 찾아서 비즈니스 로직용, 레포용 서비스 분리 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

@Schema 어노테이션 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

@Schema 어노테이션 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

@Schema 어노테이션 필요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

  • 이거 지워주세요~~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

없어지나요?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

삭제 요망

Copy link
Member

@clainyun clainyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 확인 다 했습니다!

@wdd1016 wdd1016 self-requested a review May 23, 2025 05:51
Copy link
Contributor

@wdd1016 wdd1016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wdd1016 wdd1016 merged commit 7f91462 into develop May 23, 2025
1 check passed
gwangbu-desu pushed a commit that referenced this pull request May 24, 2025
@wdd1016 wdd1016 deleted the chore/FRB-173 branch June 3, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: 디렉토리 구조 개선 및 공통 응답 설정

5 participants