Skip to content

Fix GameObjects in GameObjectSystem NetLists being null on clients #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andy013 wants to merge 2 commits into from
Closed

Fix GameObjects in GameObjectSystem NetLists being null on clients #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
340b857
Fixes GameObject references in GameObjectSystem NetLists and NetDicti…
andy013 Dec 9, 2025
ccbf987
dotnet format
andy013 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions engine/Sandbox.Engine/Scene/Networking/SceneNetworkSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,18 +418,6 @@ public override async Task SetSnapshotAsync( SnapshotMsg msg )
Time.Now = (float)msg.Time;
Game.ActiveScene.UpdateTimeFromHost( msg.Time );

foreach ( var s in msg.GameObjectSystems )
{
var type = Game.TypeLibrary.GetTypeByIdent( s.Type );
var system = Game.ActiveScene.GetSystemByType( type );

if ( system is null )
continue;

system.Id = s.Id;
system.ReadDataTable( s.TableData );
}

{
using var batchGroup = CallbackBatch.Batch();

Expand Down Expand Up @@ -457,6 +445,18 @@ public override async Task SetSnapshotAsync( SnapshotMsg msg )
}
}

foreach ( var s in msg.GameObjectSystems )
{
var type = Game.TypeLibrary.GetTypeByIdent( s.Type );
var system = Game.ActiveScene.GetSystemByType( type );

if ( system is null )
continue;

system.Id = s.Id;
system.ReadDataTable( s.TableData );
}

MountedVPKs?.Dispose();
MountedVPKs = null;

Expand Down
13 changes: 5 additions & 8 deletions engine/Sandbox.Engine/Scene/Scene/Scene.Network.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,13 @@ internal void SceneNetworkUpdate()
var connections = system.GetFilteredConnections( Connection.ChannelState.Connected );
var connectionsArray = connections as Connection[] ?? connections.ToArray();

if ( connectionsArray.Length != 0 )
{
var objects = networkedObjects.OfType<IDeltaSnapshot>();
var objects = networkedObjects.OfType<IDeltaSnapshot>();

// If we're the host, include any GameObjectSystems.
if ( Networking.IsHost )
objects = objects.Concat( systems );
// If we're the host, include any GameObjectSystems.
if ( Networking.IsHost )
objects = objects.Concat( systems );

system.DeltaSnapshots.Send( objects, connectionsArray );
}
system.DeltaSnapshots.Send( objects, connectionsArray );

system.DeltaSnapshots.Tick();
}
Expand Down