Prevent INetworkListener.OnDisconnected being called on clients
#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yeah we should probably have this guard, but in this particular case wouldn't the client just be booted to menu? |
Contributor
Author
|
Yes, but I think it can happen when the host transfers as well. It just happens for the people who stay as clients. I've not confirmed this though as I was only testing with 2 accounts. When I tried that the other client always became the host before |
handsomematt
added
the
triaged
Contributor
|
This PR has been merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Facepunch/sbox-issues#7746
Changes
OnDisconnectedin aIsHostif block.Notes
The XML comment says this should only be called for the host, but it could be called for the client if the host disconnected. It's a bit tricky to reproduce since you can't use the editor or a dedicated server. I had to use 2 steam accounts, disable host transfer and then disconnect the host to reproduce it.