Scope last selected SceneViewportWidget to SceneViewWidget #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove static LastSelected SceneViewportWidget. It should be scoped to the last selected viewport within a particular Scene view - Add LastSelectedViewportWidget to SceneViewWidget - Re-add focusing the last selected widget that was hotfixed in Facepunch#114
aidencurtis
force-pushed
the
scope-last-selected-viewport-to-scene-widget-view
branch
from
092894d to
67bf2af
Compare
handsomematt
added
the
triaged
Contributor
|
This PR has been merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SceneViewportWidget had a static member
public SceneViewportWidget LastSelected. This held a reference to the last selected viewport widget, but this reference should be scoped to the current SceneViewWidget instead.This change allows operations on the last selected viewport widget without concern of bleeding references from other scenes.
Summary of code changes:
cc @CarsonKompon