Sound preview misc fixes #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…increment time if playing
boxrocket6803
changed the title
… when zoomed all the way out, only show scroll bar if there's anything to scroll
… drawing in wrong position (view from last frame)
…r scrubbing, use correct offset when manipulating scrubber
Author
|
Was gonna just fix the one thing but kept seeing other stuff and figured it'd be more convenient for all involved to do a larger pr instead of a bunch of smaller ones. before 2025-12-12.19-46-22.mp4after 2025-12-12.19-47-38.mp4 |
garrynewman
added
the
triaged
Contributor
|
This PR has been merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sound preview playback previously always started at 0, now it starts at the playhead position.
2025-12-12.16-00-15.mp4
Also added a check to only increment time while actually playing, previously upon reaching the end of a file with looping disabled it would reset the playhead position then add an extra RealTime.SmoothDelta. When playing the file again the start would be cut off slightly. Now it correctly parks itself at 0.