Fix lobby data not being added to steam tags when starting a dedicated server. #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy013
changed the title
garrynewman
added
the
triaged
Contributor
|
This PR has been merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Facepunch/sbox-issues#9743
Changes
Notes
Currently if you set lobby data with
Networking.SetData()before a dedicated server has started, the steam tags are not updated. It just fails silently. This PR fixes this.It also fails silently if you exceed the 128 character limit, so I added a warning in for that.
I spent way too long playing around with the ANSI colour codes. This is what the warning looks like:
To be honest this is probably a little overkill. A comment mentions that this system will be replaced at some point in the future, but this might help for now.