Skip to content

Prevent stack overflow when selecting mesh elements (Stop recursive ToString() on mesh handles) #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aleph0x wants to merge 8 commits into from
+6 −0
Closed

Prevent stack overflow when selecting mesh elements (Stop recursive ToString() on mesh handles) #145

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
43b68e6
avoid handle recursion in MeshFace.ToString()
Aleph0x Dec 27, 2025
04fb4f9
avoid handle recursion in MeshVertex.ToString()
Aleph0x Dec 27, 2025
27951d7
Fix MeshEdge ToString recursion
Aleph0x Dec 27, 2025
b899f96
Revert "avoid handle recursion in MeshFace.ToString()"
Aleph0x Dec 27, 2025
6b8e3a2
Revert " avoid handle recursion in MeshVertex.ToString()"
Aleph0x Dec 27, 2025
d334eb9
Revert "Fix MeshEdge ToString recursion"
Aleph0x Dec 27, 2025
365eb5a
Add ToString overrides for HalfEdgeMesh handle types
Aleph0x Dec 27, 2025
185de13
fix formatting
Aleph0x Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions engine/Sandbox.Engine/Scene/Components/Mesh/HalfEdgeMesh/HalfEdgeMesh.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ public HalfEdgeHandle Edge
get => new( Mesh is null ? -1 : Mesh[this].Edge, Mesh );
set => Mesh?.SetVertexEdge( this, value );
}

public override string ToString() => Index >= 0 ? $"{Index}" : "Invalid Vertex";
}

public sealed record FaceHandle : IHandle
Expand All @@ -93,6 +95,8 @@ public HalfEdgeHandle Edge
get => new( Mesh is null ? -1 : Mesh[this].Edge, Mesh );
set => Mesh?.SetFaceEdge( this, value );
}

public override string ToString() => Index >= 0 ? $"{Index}" : "Invalid Face";
}

public sealed record HalfEdgeHandle : IHandle
Expand Down Expand Up @@ -132,6 +136,8 @@ public FaceHandle Face
get => new( Mesh is null ? -1 : Mesh[this].Face, Mesh );
set => Mesh?.SetEdgeFace( this, value );
}

public override string ToString() => Index >= 0 ? $"{Index}" : "Invalid Edge";
}

internal sealed partial class Mesh
Expand Down
Loading