Skip to content

Clean up editor tools when entering play mode #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
boxrocket6803 wants to merge 2 commits into from
+10 −0
Closed

Clean up editor tools when entering play mode #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1101309
Clean up editor tools when entering play mode, notably camera preview…
johncosfm Jan 4, 2026
8fb2a56
rename for sake of clarity, humor copilot
johncosfm Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions game/addons/tools/Code/Scene/SceneView/SceneViewportWidget.Game.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public void SetGameView()
{
GameMode.SetPlayWidget( Renderer );
IsGameView = true;
Tools.DisposeAll();
}

/// <summary>
Expand Down Expand Up @@ -83,5 +84,6 @@ public void OnPossessGame()
{
GameMode.SetPlayWidget( Renderer );
IsGameView = true;
Tools.DisposeAll();
}
}
8 changes: 8 additions & 0 deletions game/addons/tools/Code/Scene/Tools/EditorToolManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,14 @@ private void CreateToolFor( Type t )
}
}

public void DisposeAll()
{
previousHash = -1;
foreach ( var tool in ComponentTools )
tool?.Dispose();
ComponentTools.Clear();
}

/// <summary>
/// Switches to the named tool type next editor frame.
/// </summary>
Expand Down