Skip to content

Fix ComponentEditorWidget ignoring derived types #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
badandbest wants to merge 2 commits into from
Closed

Fix ComponentEditorWidget ignoring derived types #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9215267
Fix ComponentEditorWidget ignoring derived types
badandbest Jan 9, 2026
310fc03
Fix typo in GetEditorScore
badandbest Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/Sandbox.System/SerializedObject/CustomEditorAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public float GetEditorScore( SerializedProperty property )
if ( TargetType is not null && !ForMethod )
{
//
// Order by derived classes so we get the most relevent editor
// Order by derived classes so we get the most relevant editor
//
Type baseType = TargetType;
while ( baseType.BaseType != null )
Expand Down
23 changes: 22 additions & 1 deletion engine/Sandbox.Tools/Inspector/ComponentEditorWidget.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,36 @@ public ComponentEditorWidget( SerializedObject obj ) : base( null )

public static ComponentEditorWidget Create( SerializedObject obj )
{
var componentType = TypeLibrary.GetType( obj.TypeName ).TargetType;

var editor = EditorTypeLibrary.GetTypesWithAttribute<CustomEditorAttribute>( false )
.Where( x => x.Type.TargetType.IsAssignableTo( typeof( ComponentEditorWidget ) ) )
.Where( x => x.Attribute.TargetType.Name == obj.TypeName )
.Select( x => (score: GetEditorScore( x.Attribute.TargetType, componentType ), x.Type) )
.Where( x => x.score > 0 )
.OrderBy( x => x.score )
.FirstOrDefault();

if ( editor.Type == null ) return null;
return editor.Type.Create<ComponentEditorWidget>( new object[] { obj } );
}

private static int GetEditorScore( Type targetType, Type componentType )
{
int score = 0;

//
// Order by derived classes so we get the most relevant editor
//
Type baseType = componentType;
while ( targetType.IsAssignableFrom( baseType ) )
{
score++;
baseType = baseType.BaseType;
}

return score;
}

public virtual void OnHeaderContextMenu( Menu menu )
{

Expand Down