Fixes for inline editor in collections #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This would be so nice, I end up having to create a component which is my dictionary "value" and using the editor on the component itself because the current dictionary editor is so tiny. |
Author
|
@Remscar This doesn't make anything bigger, you're looking for the WideMode attribute |
Member
|
Everything here looks just as terrible |
Author
|
perhaps a more notable improvement in a less busy scenario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Facepunch/sbox-issues#8452 and Facepunch/sbox-issues#7995
Dictionary keys no longer get stretched when using larger InlineEditor values, and it's no longer attempting to add a property name label for inline editor properties that are part of a collection (and thus don't have a name label)