Skip to content

DO-NOT-MERGE: debug #1514 #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

DO-NOT-MERGE: debug #1514 #1515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fairroot/geobase/FairGeoSet.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ using std::ios;
FairGeoSet::~FairGeoSet()
{
// Destructor
if (volumes && !volumes->IsOwner()) {
// destructing a TList that doesn't own its contents
// still touches the objects inside, even if they're
// already destroeyed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct typo in the comment.

- // already destroeyed
+ // already destroyed
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
// already destroeyed
// already destroyed

volumes->Clear("nodelete");
}
delete volumes;
volumes = 0;
delete modules;
Expand Down