Skip to content

Temporals #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Temporals #115

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ca0cb4
add temporal values
barakb Jul 2, 2025
e5aabd9
add temporal values
barakb Jul 2, 2025
21caf71
make test better
barakb Jul 16, 2025
8681f06
update cargo, add duration and its test
barakb Sep 10, 2025
2e1e0eb
fmt
barakb Sep 10, 2025
0ad621d
fix deny
barakb Sep 10, 2025
02b6a7d
fix deny
barakb Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
/codecov.json
/dump.rdb
venv/
.history
.DS_Store
6 changes: 6 additions & 0 deletions 1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Adding #[must_use] attributes to ~50+ methods
Adding # Errors sections to ~30+ functions
Fixing format string inlining in ~20+ places
Updating pub(crate) to pub in ~15+ places
Breaking long doc comments in ~10+ places
Fixing literal formatting in ~5+ places
220 changes: 208 additions & 12 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "falkordb"
version = "0.1.11"
edition = "2021"
edition = "2024"
Copy link

@coderabbitai coderabbitai bot Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Bumping to edition 2024 is risky – confirm MSRV & CI images

Edition 2024 has not hit stable as of Rust 1.79. Unless your CI/build matrix already compiles with a nightly or future stable, this will break every downstream consumer pinned to stable 1.78 or older.

-edition = "2024"
+edition = "2021"   # keep until 2024 edition reaches stable toolchains

Alternatively, document the new minimum Rust version and update CI to use the corresponding toolchain.

🏁 Script executed:

#!/bin/bash
set -e

echo "=== Checking for rust-toolchain files ==="
fd -t f rust-toolchain* || echo "No rust-toolchain files found."

echo -e "\n=== Contents of rust-toolchain files (if any) ==="
fd -t f rust-toolchain* -x cat {} || true

echo -e "\n=== Listing GitHub Actions workflow files ==="
find .github/workflows -type f || echo "No workflows directory."

echo -e "\n=== Searching workflows for Rust toolchain versions ==="
grep -R "actions-rs/toolchain" -n .github/workflows || echo "No uses of actions-rs/toolchain."
grep -R "rust-version" -n .github/workflows || echo "No rust-version fields."
grep -R "stable" -n .github/workflows || true
grep -R "nightly" -n .github/workflows || true

Length of output: 993

Confirm MSRV & CI toolchain before bumping to Edition 2024

Edition 2024 isn’t stabilized in Rust 1.79. Every downstream crate building on stable ≤1.78 will break unless we:

  • Document and enforce a new minimum Rust version (e.g. ≥1.80)
  • Update CI to install/override to nightly or the required stable toolchain

Suggested fixes:

  • Revert to 2021 edition until 2024 lands in stable toolchains, or
  • Add a rust-toolchain file or CI step (e.g. actions-rs/toolchain) to pin ≥1.80 or nightly, and update README/MSRV documentation
- edition = "2024"
+ edition = "2021"   # until Edition 2024 is supported on stable toolchains
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
edition = "2024"
edition = "2021" # until Edition 2024 is supported on stable toolchains
🤖 Prompt for AI Agents 
In Cargo.toml at line 4, the edition is set to 2024, which is not yet stabilized
in Rust 1.79 and may break builds on stable versions ≤1.78. To fix this, either
revert the edition back to 2021 until Rust 2024 is stable, or add a
rust-toolchain file or update the CI configuration to pin the Rust toolchain to
version 1.80 or nightly. Also, update the README and MSRV documentation to
reflect the new minimum Rust version requirement.

description = "A FalkorDB Rust client"
homepage = "https://www.falkordb.com/"
readme = "README.md"
Expand All @@ -16,11 +16,12 @@ all-features = true
[lib]

[dependencies]
chrono = "0.4.42"
parking_lot = { version = "0.12.4", default-features = false, features = ["deadlock_detection"] }
redis = { version = "0.32.2", default-features = false, features = ["sentinel"] }
redis = { version = "0.32.5", default-features = false, features = ["sentinel"] }
regex = { version = "1.11.1", default-features = false, features = ["std", "perf", "unicode-bool", "unicode-perl"] }
strum = { version = "0.27.1", default-features = false, features = ["std", "derive"] }
thiserror = "2.0.12"
strum = { version = "0.27.2", default-features = false, features = ["std", "derive"] }
thiserror = "2.0.16"
tokio = { version = "1.45.1", default-features = false, features = ["macros", "sync", "rt-multi-thread"], optional = true }
tracing = { version = "0.1.41", default-features = false, features = ["std", "attributes"], optional = true }

Expand Down
Loading
Loading