-
Notifications
You must be signed in to change notification settings - Fork 102
Optimizes Spell Circles #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made `reachedNumber` into `reachedSlate`and made it a long
…ts no longer doing an extra for loop at the end
Also added in small Comments
A total list of things changed:
|
vgskye
reviewed
Jul 14, 2025
Common/src/main/java/at/petrak/hexcasting/api/casting/circles/CircleExecutionState.java
Outdated
Show resolved
Hide resolved
vgskye
reviewed
Jul 14, 2025
Common/src/main/java/at/petrak/hexcasting/api/casting/circles/CircleExecutionState.java
Show resolved
Hide resolved
vgskye
reviewed
Jul 14, 2025
Common/src/main/java/at/petrak/hexcasting/api/casting/circles/CircleExecutionState.java
Outdated
Show resolved
Hide resolved
vgskye
reviewed
Jul 14, 2025
Common/src/main/java/at/petrak/hexcasting/api/casting/circles/CircleExecutionState.java
Outdated
Show resolved
Hide resolved
vgskye
reviewed
Jul 14, 2025
Common/src/main/java/at/petrak/hexcasting/api/casting/circles/CircleExecutionState.java
Outdated
Show resolved
Hide resolved
Went through these and fixed the local version. I'll make a push once there are no more random problems with the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.20 Spell Circles can loop on their own slate, however this can cause massive NBT-Leaks due to the same positions stacking on the same positions. This PR just makes reachedPositions a HashSet/Set, and adds an extra Int Var of "reachedNumber", or how many slates it has come across (this is for the speed up of Spell Circles).