Skip to content

Refs #426: Add wikilink filename-with-spaces regression test#438

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/426-1773016073-wikilink-spaces
Open

Refs #426: Add wikilink filename-with-spaces regression test#438
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/426-1773016073-wikilink-spaces

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a regression test for issue #426 covering go-to-definition resolution for a wikilink pointing at a Markdown filename containing spaces.

The new test creates a temporary vault with:

  • source.md containing [[git command]]
  • git command.md as the target file

It then constructs a Vault, calls goto_definition, and asserts that exactly one definition is returned and that it points to git command.md.

Review & Testing Checklist for Human

  • Confirm a test-only change is appropriate for Filenames containing spaces are not supported in wikilinks. #426, since the current resolver already handles the literal [[git command]] case.
  • Verify the test captures the user-reported “jump” behavior accurately enough, or decide whether additional editor/LSP coverage is needed.
  • Run cargo test gotodef::tests::wiki_link_to_filename_with_spaces_resolves or the full test suite locally if desired.

Notes

No production resolver logic is changed in this PR.

Link to Devin session: https://app.devin.ai/sessions/fe48ade6ff2f43a3a702a4652f42495f
Requested by: @Feel-ix-343


Open in Devin Review

Refs #426

Co-Authored-By: Felix Zeller <felixazeller@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant