Ignore references overlapping inline code spans#455
Open
thynomex wants to merge 1 commit into
Open
Conversation
Author
|
/claim #269 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269
/claim #269
This fixes the false unresolved-reference diagnostic for literal
[[and]]markers inside inline code spans.Root cause: the codeblock filter only ignored references fully contained inside a code span. The reported text can create a single wikilink regex match that starts inside the first inline code span and ends inside the second, so it was not fully contained by either span.
Changes:
Rangeablevalues.references_in_codeblocksis disabled.[[/]]case while preserving a normal wikilink outside code.Validation:
cargo test references_overlapping_inline_code_are_ignored-> passedcargo fmt --check-> passedcargo test-> 75 passed