Ignore wikilinks that overlap inline code spans#461
Open
6crucified wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #269
Summary
`[[` ... `]]`inline-code false positiveWhy
The current wikilink regex can span from
`[[`in one inline code span to`]]`in another. That produces a false unresolved reference because the match overlaps multiple code spans and is not filtered out by the existing containment check.Validation
cargo fmt --checkgit diff --check -- src/vault/mod.rsNote: I attempted to run a focused
cargo testfor the new regression locally, but the first full test-binary build for this repo was unusually slow in this environment and did not complete within the time budget.