Skip to content

[Android] Should Initialize MMKV from MainActivity #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Android] Should Initialize MMKV from MainActivity #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ repositories {
}

dependencies {
//noinspection GradleDynamicVersion
implementation 'com.facebook.react:react-native:+'
implementation 'com.tencent:mmkv-static:1.2.10'
}
Expand Down
16 changes: 4 additions & 12 deletions android/src/main/java/com/fidme/faststorage/RNFastStorageModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ public void setItem(String key, String value, Promise promise) {
MMKV kv = MMKV.defaultMMKV();
kv.encode(key, value);
promise.resolve(value);
} catch (Error e) {
promise.reject("Error", "Unable to setItem");
} catch (Exception e) {
} catch (Error | Exception e) {
promise.reject("Error", "Unable to setItem");
}
}
Expand All @@ -44,9 +42,7 @@ public void getItem(String key, Promise promise) {
try {
MMKV kv = MMKV.defaultMMKV();
promise.resolve(kv.decodeString(key));
} catch (Error e) {
promise.reject("Error", "Unable to getItem");
} catch (Exception e) {
} catch (Error | Exception e) {
promise.reject("Error", "Unable to getItem");
}
}
Expand All @@ -57,9 +53,7 @@ public void removeItem(String key, Promise promise) {
MMKV kv = MMKV.defaultMMKV();
kv.removeValueForKey(key);
promise.resolve(key);
} catch (Error e) {
promise.reject("Error", "Unable to removeItem");
} catch (Exception e) {
} catch (Error | Exception e) {
promise.reject("Error", "Unable to removeItem");
}
}
Expand All @@ -70,9 +64,7 @@ public void clearStore(Promise promise) {
MMKV kv = MMKV.defaultMMKV();
kv.clearAll();
promise.resolve("Done");
} catch (Error e) {
promise.reject("Error", "Unable to removeItem");
} catch (Exception e) {
} catch (Error | Exception e) {
promise.reject("Error", "Unable to removeItem");
}
}
Expand Down
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {NativeModules} from 'react-native';
import { NativeModules, Platform } from 'react-native';

const {RNFastStorage} = NativeModules;
const { RNFastStorage } = NativeModules;

if (RNFastStorage.setupLibrary) RNFastStorage.setupLibrary();
if (Platform.OS === 'ios' && RNFastStorage.setupLibrary) RNFastStorage.setupLibrary();

export default {
...RNFastStorage,
Expand Down