feat: Merge createDataset and addPieces for streamlined dataset creation #201
+358
−148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the feature described in #171 at filecoin-services to merge
createDataset
andaddPieces
operations for a streamlined user experience.Changes
PDP Verifier Updates
addPieces
function: Now accepts(datasetID, listenerAddress, pieces, extraData)
parametersdatasetID = NEW_DATA_SET_SENTINEL
(type(uint256).max) with a validlistenerAddress
to create a new dataset and add pieces in a single transactionlistenerAddress = 0
with an existingdatasetID
to add pieces to existing datasetscreateDataset
method: No longer needed as functionality is merged intoaddPieces
Test Improvements
TestConstants.sol
for shared constants likeNEW_DATA_SET_SENTINEL
Benefits
Testing
Related Issue
Closes #171 at filecoin-services