feat: add createDataSetWithPieces method for combined dataset creation and piece addition #287
+535
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and piece addition - Introduced `createDataSetWithPieces` method in `PDPServer` to allow creating a new data set with pieces in a single operation. - Added corresponding type `CreateDataSetWithPiecesResponse` for the new response structure. - Implemented `uploadAndCreate` method in `StorageContext` and `StorageManager` to streamline data upload and dataset creation. - Enhanced tests to cover scenarios for successful dataset creation with and without pieces, including validation for piece metadata and CID.
|
@virajbhartiya please see the notes I left in #264 about how this should go - it's not a new method, it replaces the current flow and has some subtleties to how it all works. You need to pay careful attention to how the pieces are moving in here and not just add new functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createDataSetWithPiecesmethod inPDPServerto allow creating a new data set with pieces in a single operation.CreateDataSetWithPiecesResponsefor the new response structure.uploadAndCreatemethod inStorageContextandStorageManagerto streamline data upload and dataset creation.Ref filecoin-project/curio#678
Curio PR: filecoin-project/curio#687