Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.5 #18

Merged
merged 7 commits into from
Feb 9, 2024
Merged

v0.1.5 #18

merged 7 commits into from
Feb 9, 2024

Conversation

nickvido
Copy link
Collaborator

@nickvido nickvido commented Feb 2, 2024

v0.1.5

New Features

  • Updated _create_GET_FINDINGS_VARIABLES to handle category as either a string or list
  • Updated get_findings to take a single finding_id parameter to get a single finding
  • Updated get_findings to take a limit parameter to get a limited number
  • Added update_finding_statuses method
  • Added examples/update_finding_status.py example script

Breaking Changes

N/A

Bug Fixes

N/A

Testing Notes

  • All previous tests passing against prod integration test
  • New tests (test_0_1_5):
    • test_categories_on_findings_string_or_array
    • test_categories_on_findings_string_or_array
    • test_get_single_finding_by_id
    • test_get_findings_with_limit
    • test_update_finding_status_affected
    • test_update_finding_status_affected_with_no_response
    • test_update_finding_status_affected_with_no_response_no_comment
    • test_update_finding_status_not_affected
    • test_update_finding_status_not_affected_with_no_justification
    • test_update_finding_status_not_affected_with_no_justification_no_comment
    • test_update_finding_status_affected_mismatch_with_justification
    • test_update_finding_status_not_affected_mismatch_with_response
    • test_update_finding_under_investigation
    • test_update_finding_fixed
    • test_update_multiple_findings

@nickvido nickvido marked this pull request as ready for review February 7, 2024 21:56
@nickvido nickvido requested a review from ortizjd February 8, 2024 15:54
Copy link
Collaborator

@axelthibodeau axelthibodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a ton about the sdk code but this looks good to me!

@nickvido nickvido merged commit cdd37bf into main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants