[ASOC-2434] Upload method on upload functions #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and better doc in create_new_asset_version_and_upload_binary
facundoArgeniss
changed the title
Comment on lines
+1513
to
+1514
| raise Exception( | ||
| "Error: Export Job ID not found - this should not happen, please contact your Finite State representative") |
There was a problem hiding this comment.
this looks like wonky formatting
Comment on lines
-1372
to
+1501
| mutation = queries.LAUNCH_REPORT_EXPORT['mutation'](asset_version_id=asset_version_id, product_id=product_id, report_type=report_type, report_subtype=report_subtype) | ||
| variables = queries.LAUNCH_REPORT_EXPORT['variables'](asset_version_id=asset_version_id, product_id=product_id, report_type=report_type, report_subtype=report_subtype) | ||
| mutation = queries.LAUNCH_REPORT_EXPORT['mutation'](asset_version_id=asset_version_id, product_id=product_id, | ||
| report_type=report_type, report_subtype=report_subtype) | ||
| variables = queries.LAUNCH_REPORT_EXPORT['variables'](asset_version_id=asset_version_id, product_id=product_id, | ||
| report_type=report_type, report_subtype=report_subtype) |
There was a problem hiding this comment.
this just a formatting change? these looked better before
axelthibodeau
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.1.16
New Features
Add upload method argument in all uploading functions.
Breaking Changes
N/A
Bug Fixes
N/A