[ASOC-2714] fix multipart code and chun ksize #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edhubbard1994
approved these changes
Jun 11, 2024
KK7NZY
reviewed
Jun 11, 2024
finite_state_sdk/__init__.py
Outdated
| def upload_file_for_binary_analysis(token, organization_context, test_id=None, file_path=None, | ||
| chunk_size=1024 * 1024 * 1024 * 5, quick_scan=False): | ||
| def upload_file_for_binary_analysis( | ||
| token, organization_context, test_id=None, file_path=None, chunk_size=1024**2 * 1000, quick_scan=False |
There was a problem hiding this comment.
To enhance readability and maintainability, I recommend defining this value chunk_size as a constant at the beginning of the script or into another module.
finite_state_sdk/__init__.py
Outdated
| if not test_id: | ||
| raise ValueError("Test Id is required") | ||
| if not file_path: | ||
| raise ValueError("File Path is required") | ||
| if chunk_size < 1024**2 * 5: |
There was a problem hiding this comment.
Recommend moving these values to a constant at the beginning of this script or to another module.
KK7NZY
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: SDK Errors On Large Files.
Solution based on this thread in StackOverflow https://stackoverflow.com/questions/70131487/an-error-occurred-entitytoosmall-when-calling-the-completemultipartupload-oper