[ASOC-2886] Add retries when sending graphql requests #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finite_state_sdk/__init__.py
Outdated
| return records | ||
|
|
||
|
|
||
| @retry(stop=stop_after_attempt(10), wait=wait_fixed(10), retry=retry_if_exception(is_not_breakout_exception)) |
There was a problem hiding this comment.
i think this is too many retries, maybe 3? 5? how long does the test take to run?
Comment on lines
+78
to
+79
| # Call the function and expect a RetryError | ||
| with pytest.raises(tenacity.RetryError) as excinfo: |
There was a problem hiding this comment.
if this test takes too long to run (cause of all the retries) you can add a send_graphql_query.retry.wait = wait_fixed(0) in the test itself to override the wait
There was a problem hiding this comment.
It only takes couple minutes.
| # Assertion | ||
| assert str(excinfo.value) == "Error: 500 - Internal Server Error" | ||
| # Check the inner exception message | ||
| inner_exception = excinfo.value.last_attempt.exception() |
There was a problem hiding this comment.
could also assert the number of calls to post here
axelthibodeau
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASOC-2886 - Fixed an issue with the SDK that was either not working or failing intermittently. Added retries (up to 10 times) for queries, but skips retries for mutations.