Skip to content

feat(banim): Extract battle animation assets from baserom into source files #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laqieer wants to merge 40 commits into
base: master
Choose a base branch
from
Open

feat(banim): Extract battle animation assets from baserom into source files #735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
b6a1f3a
Backup and switch model
laqieer Feb 28, 2026
8d6fbba
Document battle animation asset extraction workflow
laqieer Feb 28, 2026
e99cc60
Document palette, gbagfx, TSA, and animscr rules
laqieer Feb 28, 2026
e0a53b6
Record agent metadata for documentation update
laqieer Feb 28, 2026
494cffb
Add Feishu chat process log for banim tasks
laqieer Feb 28, 2026
19f65d6
Extend banim process log with Feb 27 chat history
laqieer Feb 28, 2026
d452169
Reorganize banim asset extraction doc with edge cases
laqieer Feb 28, 2026
e7a9046
Track banim palette sources and update log
laqieer Feb 28, 2026
1636d5d
Handle high-bit banim palettes via agbpal sources
laqieer Feb 28, 2026
72c277d
Revert "Handle high-bit banim palettes via agbpal sources"
laqieer Feb 28, 2026
14e74ee
Log ROM asset parity verification
laqieer Feb 28, 2026
1e9c6c2
Reapply high-bit palette extraction
laqieer Feb 28, 2026
a5096ee
Restore ROM-incbin banim assets and log rebuild\n\nAgent: Nightfall |…
laqieer Feb 28, 2026
f892a9a
Document palette pipeline restoration rebuild\n\nAgent: Nightfall | M…
laqieer Feb 28, 2026
a4e7228
Use gbagfx for palette conversion and enforce CRLF checkout\n\nAgent:…
laqieer Feb 28, 2026
28e9063
Split ROM incbins for four banim assets\n\nAgent: Nightfall | Model: …
laqieer Feb 28, 2026
f2b125c
Extract remaining banim tail assets\n\nAgent: Nightfall | Model: gith…
laqieer Feb 28, 2026
c383f0d
Surface misc TSA sources\n\nAgent: Nightfall | Model: github-copilot/…
laqieer Feb 28, 2026
0657c3b
add remaining slices
laqieer Feb 28, 2026
3698f27
Restore Magdhis PNG for build\n\nAgent: Nightfall | Model: github-cop…
laqieer Feb 28, 2026
2dbde71
Document banim extraction best practices\n\nAgent: Nightfall | Model:…
laqieer Feb 28, 2026
3378dbd
Clarify extraction validation steps\n\nAgent: Nightfall | Model: gith…
laqieer Feb 28, 2026
8811e4c
Record build+trailer policy\n\nAgent: Nightfall | Model: github-copil…
laqieer Feb 28, 2026
3c1cab6
Extract residual slices into native assets\n\nAgent: Rennac | Model: …
laqieer Feb 28, 2026
1747f56
Fix misidentified palette assets\n\n- Convert 006926E0_Pal_IvaldiSpri…
laqieer Feb 28, 2026
f71cca1
docs: Document Banim TSA and Img preservation necessity
laqieer Mar 1, 2026
6c50a0f
graphics: Add PNG previews for banim TSA frames
laqieer Mar 1, 2026
5ed49b3
docs: Append pokeemerald validation to TSA report
laqieer Mar 1, 2026
0737ab6
data/banim: Disassemble AnimScr_NaglfarBG4 + AnimScr_DarkBreath_Far
laqieer Mar 1, 2026
b708726
build(banim): Replace AnimScr binary blobs with assembly source
laqieer Mar 1, 2026
a6041da
docs: Add Banim AnimScr decompilation & linker pipeline report
laqieer Mar 1, 2026
f680c32
docs: remove banim_followups.md as the task is completed
laqieer Mar 1, 2026
8322383
build(banim): remove .tsa.lz intermediate build artifacts from repo
laqieer Mar 1, 2026
e1b0a44
build(banim): remove remaining intermediate .lz artifacts from repo
laqieer Mar 1, 2026
0bc00df
docs: translate documentation to English for PR
laqieer Mar 1, 2026
f380f4b
scripts(banim): clean up temporary script versions
laqieer Mar 1, 2026
87c43fe
chore: remove preview PNGs and redundant docs to streamline PR
laqieer Mar 1, 2026
0684549
Merge branch 'master' into banim-assets-source and resolve conflicts
laqieer Mar 1, 2026
d1e0deb
Restore banim assets wrongly deleted by upstream merge
laqieer Mar 1, 2026
5a1c626
Restore banim_img_rules.mk, reports, and scripts deleted by upstream …
laqieer Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

*.bin binary

# Declare files that will always have CRLF line endings on checkout.
# Palettes must always check out with CRLF endings (Feishu directive 2026-02-28).
*.pal text eol=crlf

# Declare files that will always have LF line endings on checkout.
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ tools/agbcc
*.4bpp
*.8bpp
*.gbapal
!*.pal
!*.agbpal
*.4bpp.h
*.8bpp.h
*.lz
Expand Down
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ JSONPROC := tools/jsonproc/jsonproc$(EXE)
FETSATOOL := scripts/gfxtools/tsa_generator.py
TMAP2TSA := scripts/tmap2tsa.py
MARTOMAP := scripts/mar_to_map.py
PYTHON ?= python3
PAL2GBAPAL := $(GBAGFX)

ifeq ($(UNAME),Darwin)
SED := sed -i ''
Expand Down Expand Up @@ -156,6 +158,7 @@ src/msg_data.c: $(TEXT_SRC) $(TEXT_DEFS)
# Graphics Recipes

include graphics_file_rules.mk
include graphics/banim/assets/img/banim_img_rules.mk
include songs.mk
include json_data_rules.mk

Expand All @@ -167,7 +170,7 @@ include json_data_rules.mk
%.1bpp: %.png ; $(GBAGFX) $< $@
%.4bpp: %.png ; $(GBAGFX) $< $@
%.8bpp: %.png ; $(GBAGFX) $< $@
%.gbapal: %.pal ; $(GBAGFX) $< $@
%.gbapal: %.pal ; $(PAL2GBAPAL) $< $@
%.gbapal: %.png ; $(GBAGFX) $< $@
%.lz: % ; $(GBAGFX) $< $@
%.rl: % ; $(GBAGFX) $< $@
Expand Down
Loading