Filter out node_modules without breaking nx monorepos #352
Conversation
Yuangwang
requested review from
sjjj986,
jamesdaniels,
annajowang,
blidd-google,
taeold and
leoortizz
as code owners
| @@ -191,6 +193,14 @@ async function generateBundleYaml( | |||
| frameworkVersion: nextVersion, | |||
| }, | |||
| }; | |||
| if (!process.env.MONOREPO_COMMAND) { | |||
There was a problem hiding this comment.
What will be the mechanism for handling output files when it is a monorepo then, does this mean we do not delete any files without serverApp being set?
There was a problem hiding this comment.
Nx monorepos at least will behave as they've always behaved in the past, nothing is deleted
| @@ -191,6 +193,14 @@ async function generateBundleYaml( | |||
| frameworkVersion: nextVersion, | |||
| }, | |||
| }; | |||
| if (!process.env.MONOREPO_COMMAND) { | |||
There was a problem hiding this comment.
i think proper behavior is that we support monorepo projects as well.
But I can see how that's a hassle now and requires some careful rethinking.
can we leave a TODO here linking to a bug?
There was a problem hiding this comment.
Yeah can create a bug and link it here to support nx monorepos properly. I don't have much experience there right now so I don't know immediately how to solve this issues since the standalone build doesn't come with a node_modules for some reason but adding the todo will be a good reminder for later anyways
Round 2 of filtering out node_modules, this time with a carve out to avoid breaking monorepos