Move the call of the checkArgsMismatch function before the call of th… - #8242
Merged
dyemanov merged 2 commits intoOct 7, 2025
Merged
Conversation
…e setParamsFunc function
…rom pass2() to parse().
Member
|
This PR have no lables, please add |
hvlad
pushed a commit
that referenced
this pull request
Jun 12, 2026
* Move the call of the checkArgsMismatch function before the call of the setParamsFunc function * Replace unneeded checks with asserts. Move the JRD-level validation from pass2() to parse(). --------- Co-authored-by: Alexander Zhdanov <alexander.zhdanov@red-soft.ru> Co-authored-by: Dmitry Yemanov <dyemanov@users.noreply.github.com>
hvlad
pushed a commit
that referenced
this pull request
Jun 12, 2026
* Move the call of the checkArgsMismatch function before the call of the setParamsFunc function * Replace unneeded checks with asserts. Move the JRD-level validation from pass2() to parse(). --------- Co-authored-by: Alexander Zhdanov <alexander.zhdanov@red-soft.ru> Co-authored-by: Dmitry Yemanov <dyemanov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e setParamsFunc function
Why checkArgsMismatch is executed after the setParamsFunc function and not before it? I think it is more logical to make the checkArgsMismatch check at the place where I put it in the PR. This location is more advantageous because there will be no need to do extra work in the form of calling the setParamsFunc function and other things if you know in advance that the number of arguments is incorrect.
Also, thanks to this location, we don't need to add the “if (argsCount > 1)” check to the setParamsMakeDbKey function, which saves us from unnecessary branching. If you are happy with this solution, I can remove these checks in the existing setParams functions.
I doubt about removing the checkArgsMismatch function call in SysFuncCallNode::pass2.
I haven't found what it might affect and don't understand why it was there.