Open
Conversation
waqas-anonymco
approved these changes
Feb 18, 2026
waqas-anonymco
left a comment
waqas-anonymco
left a comment
There was a problem hiding this comment.
Scripts look good to me. Added few minor points.
| if [ -z "$HF_TOKEN" ]; then | ||
| echo "HF_TOKEN is not set. Please enter your Hugging Face token:" | ||
| read -s HF_TOKEN | ||
| echo "HF_TOKEN set: $HF_TOKEN" |
There was a problem hiding this comment.
We shouldn't log $HF_TOKEN on screen.
| "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu \ | ||
| $(. /etc/os-release && echo "$VERSION_CODENAME") stable" | \ | ||
| sudo tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
| sudo apt-get update |
There was a problem hiding this comment.
Probably don't need do call update again here.
| # Exit immediately if a command exits with a non-zero status. | ||
| set -e | ||
|
|
||
| # Parse command-line arguments |
There was a problem hiding this comment.
We can add sudo apt upgrade -y to this script as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.