Skip to content

Update HeaderExtractor to enable REDIRECT_HTTP_AUTHORIZATION #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update HeaderExtractor to enable REDIRECT_HTTP_AUTHORIZATION #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc32238
Update HeaderExtractor to enable REDIRECT_HTTP_AUTHORIZATION
Martimiz May 10, 2018
9f68b3f
Remove Globals from code
Martimiz May 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Helpers/HeaderExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Firesphere\GraphQLJWT\Helpers;

use SilverStripe\Control\HTTPRequest;
use \SilverStripe\Core\Environment;

class HeaderExtractor
{
Expand All @@ -14,6 +15,13 @@ class HeaderExtractor
public static function getAuthorizationHeader(HTTPRequest $request)
{
$authHeader = $request->getHeader('Authorization');
if (!$authHeader) {
$envVars = Environment::getVariables();
if (isset($envVars['_SERVER']['REDIRECT_HTTP_AUTHORIZATION'])) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be an .htaccess setting, which should forward the HTTP authorisation. Not something inside the scope of this module?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late, but on second thought, I do see value in this, but I'd rather not reed directly from a header, could you update this to use filter_input?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I could, shouldn’t be hard. But it’s been a while and I don’t have that setup anymore where this was an issue, so can’t actually test it now. Try to find a moment to set something up...

$authHeader = $envVars['_SERVER']['REDIRECT_HTTP_AUTHORIZATION'];
}
}

if ($authHeader && preg_match('/Bearer\s+(.*)$/i', $authHeader, $matches)) {
return $matches;
}
Expand Down