Skip to content

Fix weights on GPU #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 15, 2021
Merged

Fix weights on GPU #41

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e1cad06
simplify progressbar
matthieugomez Oct 17, 2020
c8ae745
Update FixedEffectSolverCPU.jl
matthieugomez Oct 17, 2020
51421b6
Update progressbar.jl
matthieugomez Oct 17, 2020
1db684c
Update FixedEffectSolverCPU.jl
matthieugomez Oct 17, 2020
eec1dcc
correct weights
matthieugomez Nov 15, 2020
fcfe23e
Merge branch 'master' of https://github.com/matthieugomez/FixedEffect…
matthieugomez Nov 15, 2020
b9ec8cb
Update Project.toml
matthieugomez Nov 15, 2020
e6ef6c7
Fixing `nthreads`
Feb 4, 2021
643148d
merged update_weights!
Feb 12, 2021
96db859
removed duplicate weights creation
Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/FixedEffectSolvers/FixedEffectSolverGPU.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ function AbstractFixedEffectSolver{T}(fes::Vector{<:FixedEffect}, weights::Abstr
h = FixedEffectCoefficients([cuzeros(T, fe.n) for fe in fes])
hbar = FixedEffectCoefficients([cuzeros(T, fe.n) for fe in fes])
tmp = zeros(T, length(weights))
update_weights!(FixedEffectSolverGPU{T}(m, weights, b, r, x, v, h, hbar, tmp, fes), weights)
update_weights!(FixedEffectSolverGPU{T}(m, cuzeros(T, length(weights)), b, r, x, v, h, hbar, tmp, fes), weights)
end


function update_weights!(feM::FixedEffectSolverGPU{T}, weights::AbstractWeights) where {T}
weights = cu(T, collect(weights))
weights = cu(T, weights)
nthreads = feM.m.nthreads
for (scale, fe) in zip(feM.m.scales, feM.m.fes)
scale!(scale, fe.refs, fe.interaction, weights, nthreads)
Expand Down