Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max/min other value when int dtype and add int dtype tests #494

Merged
merged 8 commits into from
Mar 24, 2025
+166 −62
Merged

Fix max/min other value when int dtype and add int dtype tests #494

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e053ae0
Fix max other value
0x45f Mar 17, 2025
6b8120d
Format code
0x45f Mar 17, 2025
f5bd9d6
Fix code
0x45f Mar 17, 2025
1236c98
Fix min
0x45f Mar 18, 2025
13ccb47
add limits to get max/min for integer types and inf/-inf for floating…
iclementine Mar 18, 2025
ac1587b
fix amax
iclementine Mar 20, 2025
7ef2341
use int64 index for index_put
iclementine Mar 21, 2025
c853eb0
upcast inputs for index_put
iclementine Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format code
@0x45f @iclementine
0x45f authored and iclementine committed Mar 20, 2025
commit 6b8120d8204ab3f34db49a88fd952370246574ba
1 change: 0 additions & 1 deletion src/flag_gems/ops/max.py
View file
Original file line number Diff line number Diff line change
@@ -27,7 +27,6 @@ def max_kernel_1(
mask = offset < M
inp_val = tl.load(inp_ptrs, mask=mask, other=DTYPE_MIN)
max_val = tl.max(inp_val)
# tl.device_print("max_val: ", max_val)
mid_ptr = mid + pid
tl.store(mid_ptr, max_val)