Add gelu and mul grad #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongxin
reviewed
Mar 20, 2025
| @triton.jit | ||
| def gelu_none_and_mul_grad_kernel(x, y, dgrad): | ||
| x_fp32 = x.to(tl.float32) | ||
| x_gelu = 0.5 * x_fp32 * (1 + erf(x_fp32 * 0.7071067811)) |
There was a problem hiding this comment.
Shall we give a named symbol to the constant? Or just 2**-0.5
tongxin
reviewed
Mar 20, 2025
Comment on lines
+32
to
+38
| d_gelu = 0.5 * ( | ||
| 1.0 | ||
| + erf(x_fp32 * 0.7071067811) | ||
| + x_fp32 * coeff * tl.exp(-0.5 * x_fp32 * x_fp32) | ||
| ) | ||
|
|
||
| dx = dgrad * y * d_gelu |
There was a problem hiding this comment.
I would suggest following the naming convention in chain rule. In this particular case,
d_gelu = d_out * y
dx = d_gelu * 0.5 * (
1.0
+ erf(x_fp32 * 0.7071067811)
+ x_fp32 * coeff * tl.exp(-0.5 * x_fp32 * x_fp32)
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Type of Change
Description
Issue
Progress
Performance