Disable InfluxDB in values by default #229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are no longer using InfluxDB as the default for all new Flagsmith deployments. Disabling it by default in Helm values removes a possible point of friction, for example for customers that require all container images be mirrored in internal repositories. I understand this should only affect new deployments, but feel free to ignore or close this PR if it would cause any problems.
|
Ignore this PR, see #133 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
/charts/flagsmith/Chart.yamlin the sectionversionor I'm merging to arelease branch
Changes
We are no longer using InfluxDB as the default for all new Flagsmith deployments. Disabling it by default in Helm values removes a possible point of friction, for example for customers that require all container images be mirrored in internal repositories.
I understand this should only affect new deployments, but feel free to ignore or close this PR if it would cause any problems.
How did you test this code?
Not tested directly, but validated this change live with a customer that requires all images to be sourced from internal repositories.