-
Notifications
You must be signed in to change notification settings - Fork 462
feat: segment feature state view #6137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: segment feature state view #6137
Conversation
…ponentise-feature-filters
…ponentise-feature-filters
…ponentise-feature-filters
…eature-state-view
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
Co-authored-by: Zaimwa9 <[email protected]>
…rs' into chore/componentise-feature-filters
…ponentise-feature-filters # Conflicts: # frontend/web/components/pages/UserPage.tsx
…eature-state-view
Yeah, I guess this makes sense with the current functionality. It is quite annoying to have to find the segment in the list still after clicking the row though. I wonder if there's an option here to add an extra step to creating a segment override which adds a confirmation button next to the drop down in the modal, then we could pre-fill the drop down when you click the row? Maybe that's overkill, but I do feel that the UX here is a little janky. |
…ent-feature-state-view
talissoncosta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me on the engineering side, great work!
matthewelwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually.
Agreed with Kyle that this is a good compromise. I still think the UX could be improved, but I'm not really sure how to do that without a larger overhaul of the segment overrides UX in the modal.
1c117d7
into
chore/componentise-feature-override-row


Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Places the associated features page with the following
Opening a feature from this view simply opens the feature modal with the segment overrides tab selected.
How did you test this code?
Requires #6156