Integrate eslint #36
Closed
Integrate eslint #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
For migration, we should have a branch without any applied formatting changes such that ESLint can easily be merged into all our ongoing branches without conflicts due to formatting. |
tonyketcham
reviewed
Jul 20, 2022
Comment on lines
+4
to
+6
| extends: | ||
| - eslint:recommended | ||
| - plugin:@typescript-eslint/recommended |
Collaborator
There was a problem hiding this comment.
Do we also want this to extend prettier so that it turns off syntax formatting rules that Prettier handles?
| @@ -0,0 +1 @@ | |||
| {} | |||
Collaborator
There was a problem hiding this comment.
Let's keep this ESLint PR branched off main so that it's not dependent on any open PRs or experimental branches
1 task
Collaborator
Author
|
duplicate of #81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34
added eslint with some defaults, also added pretty-quick so prettier will only run on staged files on precommit. we have a nice long stream of warnings now about using any