Feat: sensor data source type filter#2127
Merged
Merged
Conversation
Context: - Issue #2045 asks for filtering GET sensor data by data source type. - The belief query stack already accepts source type filters. Change: - Add the source_type request field. - Pass it to Sensor.search_beliefs as source_types when loading sensor data. Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Context: - Issue #2045 adds source_type filtering to GET sensor data. - The endpoint description lists supported optional query parameters. Change: - Mention source_type in the GET sensor data endpoint description. Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Context: - Issue #2045 needs coverage for source type filtering on GET sensor data. - The existing sensor data fixture includes user and demo script sources. Change: - Add matching user and demo script source_type cases. - Add a non-matching scheduler source_type case returning empty values. Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for filtering sensor data retrieval by data source type on the v3.0 sensor data endpoint, leveraging the existing search_beliefs(..., source_types=...) filtering in the data layer.
Changes:
- Add
source_typeas an optional query/body parameter forGET /api/v3_0/sensors/<id>/data. - Wire the parameter into the underlying beliefs query via
source_types=[source_type]. - Add parametrized API tests covering matching and non-matching source types.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
flexmeasures/api/v3_0/tests/test_sensor_data.py |
Adds tests verifying filtering behavior for source_type. |
flexmeasures/api/v3_0/sensors.py |
Documents the new source_type optional parameter in the endpoint docs. |
flexmeasures/api/common/schemas/sensor_data.py |
Introduces source_type field in request parsing and passes it into sensor.search_beliefs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Documentation build overview
|
Flix6x
reviewed
Apr 23, 2026
Flix6x
requested changes
May 4, 2026
Signed-off-by: Mohamed Belhsan Hmida <149331360+BelhsanHmida@users.noreply.github.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Flix6x
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
source_typequery filtering toGET /api/v3_0/sensors/<id>/datasource_typesfiltering supportsource_typevalues with422documentation/changelog.rstLook & Feel
Example request:
GET /api/v3_0/sensors/<id>/data?start=2021-05-02T00:00:00+02:00&duration=PT1H20M&horizon=PT0H&unit=m³/h&resolution=PT20M&source_type=userExample response:
{"status":"PROCESSED","values":[91.5,92.1,null,null],...}Non-matching example:
source_type=schedulerreturnsvalues: [null, null, null, null]Invalid example:
source_type=returns422withSource type must not be blank.How to test
pytest flexmeasures/api/v3_0/tests/test_sensor_data.py -vtest_get_sensor_data_filtered_by_source_typetest_get_sensor_data_rejects_blank_source_typeRelated Items
closes #2045
Sign-off