Skip to content

Convert to Docker Secrets #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

Convert to Docker Secrets #234

merged 1 commit into from
Oct 14, 2025

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Oct 9, 2025

Description

Convert to Docker secrets

@hardillb hardillb requested a review from ppawlowski October 9, 2025 21:59
@hardillb hardillb self-assigned this Oct 9, 2025
@hardillb hardillb marked this pull request as ready for review October 13, 2025 10:31
ppawlowski
ppawlowski reviewed Oct 13, 2025
View reviewed changes
flowforge-docker/Dockerfile
WORKDIR /usr/src/forge/app
RUN npm install --production --no-audit --no-fund
RUN --mount=type=secret,id=npm,target=/root/.npmrc npm install --production --no-audit --no-fund

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work when built via the Build and push containers pipeline. Is this expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work if the secret is not set/empty, why will it fail?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I used wrong words - image build will complete with success. We do not provide any secrets in the workflow, so the /root/.npmrs file will be empty, though.

@ppawlowski
Copy link
Contributor

file-server and node-red containers are built in the Flowfuse/helm repo. Is this a good opportunity to remove their Dockerfiles and other related files to avoid confusion?

@hardillb
Copy link
Contributor Author

file-server and node-red containers are built in the Flowfuse/helm repo. Is this a good opportunity to remove their Dockerfiles and other related files to avoid confusion?

I still like the idea of somebody being able to clone this repo and have everything they need to build containers for Docker

@ppawlowski ppawlowski merged commit 9903a8c into main Oct 14, 2025
3 checks passed
@ppawlowski ppawlowski deleted the docker-secrets branch October 14, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppawlowski ppawlowski ppawlowski approved these changes

Assignees

@hardillb hardillb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hardillb @ppawlowski