Skip to content

Conversation

@crtEvent
Copy link
Contributor

@crtEvent crtEvent commented Apr 10, 2024

✨ Key changes

👋 To reviewers

추가된 API

스터디 가입 요청 API

  • Method: POST
  • URI: /api/vi/studies/:studyId/join-requests

스터디 가입 요청 수락 API

  • Method: PATCH
  • URI: /api/v1/studies/:studyId/join-requests/:requestId/accept

스터디 가입 요청 거절 API

  • Method: PATCH
  • URI: /api/v1/studies/:studyId/join-requests/:requestId/reject

@crtEvent crtEvent added the ✨feat 기능 label Apr 10, 2024
@crtEvent crtEvent requested review from jaea-kim and jinny-l April 10, 2024 22:33
@crtEvent crtEvent self-assigned this Apr 10, 2024
@crtEvent crtEvent linked an issue Apr 10, 2024 that may be closed by this pull request
17 tasks
Copy link
Member

@jinny-l jinny-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 고생많으셨어요!

Comment on lines 32 to 33
@CreatedDate
private Instant requestTime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseEntity에는 requestTime이 없을 텐데 이렇게 수정해도 괜찮은가요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created_time을 사용하기로 했습니다. schema.sql, ERD 에도 created_time으로 기록했어요

Comment on lines 52 to 53

return ResponseEntity.ok(null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바디가 없으면 .ok().build() 하면 됩니당!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다. 고쳤어요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feat 기능

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] 스터디 가입 요청 및 수락/거절 기능 추가

3 participants