Fix serde 1.0.220+ compatibility by updating Content deserialization #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation failures when using serde 1.0.220 or above by updating the code to handle breaking changes in serde's private API.
Problem
Starting with serde 1.0.220, the
Content
type no longer has adeserialize()
method. The deserialization mechanism was refactored to useContentVisitor
with theDeserializeSeed
trait instead. This caused compilation errors in two places:Solution
Updated the affected code to use the new deserialization pattern:
Before:
After:
Changes
crates/swc_config/src/types/bool_or_data.rs
: FixedBoolOr
deserialization to useContentVisitor
crates/ast_node/src/enum_deserialize.rs
: Updated macro-generated code for AST node enum deserializationTesting
This minimal fix ensures SWC can be used with the latest serde versions while preserving all existing functionality.
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.