Skip to content

perf: cache pg-typed table APIs #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ForbesLindesay wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: cache pg-typed table APIs #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions packages/pg-typed/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,14 @@ function getTable<TRecord, TInsertParameters>(
tableName: string,
{schemaName, defaultConnection}: Partial<PgTypedOptionsWithDefaultConnection>,
) {
const cache = new WeakMap<Queryable, Table<TRecord, TInsertParameters>>();
const getTable = (queryable: Queryable) =>
new Table<TRecord, TInsertParameters>(
queryable,
schemaName
? queryable.sql.ident(schemaName, tableName)
: queryable.sql.ident(tableName),
);
return (
queryable: Queryable | undefined = defaultConnection,
): Table<TRecord, TInsertParameters> => {
Expand All @@ -223,12 +231,7 @@ function getTable<TRecord, TInsertParameters>(
'You must either provide a "defaultConnection" to pg-typed, or specify a connection when accessing the table.',
);
}
return new Table<TRecord, TInsertParameters>(
queryable,
schemaName
? queryable.sql.ident(schemaName, tableName)
: queryable.sql.ident(tableName),
);
return mapGetOrSet(cache, queryable, getTable);
};
}
export type {Table};
Expand Down Expand Up @@ -270,14 +273,19 @@ export default function tables<TTables>(
PropertyOf<TTables[TTableName], 'insert'>
>;
} {
const tables = new Map<
string,
(queryable?: Queryable | undefined) => Table<unknown, unknown>
>();
const gt = (prop: string) => getTable(prop, options);
return new Proxy(
{},
{
get: (_target, prop, _receiver) => {
if (prop === 'then') {
return undefined;
}
return getTable(String(prop), options);
return mapGetOrSet(tables, String(prop), gt);
},
},
) as any;
Expand All @@ -288,3 +296,18 @@ type PropertyOf<T, TProp extends string> = T extends {
}
? TValue
: never;

function mapGetOrSet<TKey, TValue>(
map: {
get(key: TKey): Exclude<TValue, undefined> | undefined;
set(key: TKey, value: Exclude<TValue, undefined>): unknown;
},
key: TKey,
getValue: (key: TKey) => Exclude<TValue, undefined>,
) {
const cached = map.get(key);
if (cached !== undefined) return cached;
const fresh = getValue(key);
map.set(key, fresh);
return fresh;
}