Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): send a clear message when user wants to access to an unknown field #1186

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

Scra3
Copy link
Member

@Scra3 Scra3 commented Oct 1, 2024

linked to: CU-86c0hwqkb

This pull request addresses the unclear message issue discussed in #1181. The code frequently accesses fields without verifying their existence, leading to unclear messages.

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@Scra3 Scra3 force-pushed the improve-error-when-no-field branch from 2e45ac4 to 143d7f6 Compare October 1, 2024 12:34
@Scra3 Scra3 changed the title fix: improve error fix(schema): use getter to get column or relation to throw a clear message in case of exist file Oct 1, 2024
@Scra3 Scra3 changed the title fix(schema): use getter to get column or relation to throw a clear message in case of exist file fix(schema): send a clear message when user want to access to an unknown field Oct 1, 2024
@Scra3 Scra3 force-pushed the improve-error-when-no-field branch from 143d7f6 to f3ed6f9 Compare October 1, 2024 12:43
@Scra3 Scra3 force-pushed the improve-error-when-no-field branch from f3ed6f9 to 377cff4 Compare October 1, 2024 12:52
alban bertolini added 2 commits October 1, 2024 15:07
@Scra3 Scra3 force-pushed the improve-error-when-no-field branch from 362862e to ca39b45 Compare October 1, 2024 17:28
@Scra3 Scra3 force-pushed the improve-error-when-no-field branch 4 times, most recently from c455871 to 3b38a03 Compare October 2, 2024 04:42
@Scra3 Scra3 force-pushed the improve-error-when-no-field branch from 3b38a03 to 25bd200 Compare October 2, 2024 04:49
@Scra3 Scra3 force-pushed the improve-error-when-no-field branch from a940b1c to ba86837 Compare October 2, 2024 06:37
@Scra3 Scra3 force-pushed the improve-error-when-no-field branch 10 times, most recently from 6f01abf to 4eec229 Compare October 2, 2024 09:36
@Scra3 Scra3 changed the title fix(schema): send a clear message when user want to access to an unknown field fix(schema): send a clear message when user wants to access to an unknown field Oct 2, 2024
forest-bot added a commit that referenced this pull request Oct 4, 2024
## [1.10.4](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.10.4) (2024-10-04)

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
# [1.48.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
# [1.53.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.22 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 4, 2024
## [1.1.32](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.10.4 🎉

The release is available on [email protected]

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 4, 2024
## [1.8.2](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
# [1.4.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
## [1.10.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
## [1.14.27](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
# [1.41.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
## [1.11.19](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.48.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 4, 2024
## [1.33.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
# [1.4.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
## [1.1.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
# [1.3.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.53.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.32 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.8.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.10.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.14.27 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.41.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.11.19 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.33.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.1.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 1.3.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants