Skip to content

Comments

chore(eventsource): update eventsource to v3#1230

Open
jeffladiray wants to merge 6 commits intomainfrom
chore/migrate-to-eventsource-3
Open

chore(eventsource): update eventsource to v3#1230
jeffladiray wants to merge 6 commits intomainfrom
chore/migrate-to-eventsource-3

Conversation

@jeffladiray
Copy link
Contributor

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@jeffladiray jeffladiray force-pushed the chore/migrate-to-eventsource-3 branch from f61886f to 0c036b1 Compare December 19, 2024 14:49
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit abebb3d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2% (0.0% change).

View more on Code Climate.

@jeffladiray
Copy link
Contributor Author

Still need to validate why we still are in 18.14 for the CI build, the reconnectInterval issuen and to triple check that it was safe to remove the .once function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants