feat: support for mongoose v8 #1241

DayTF · 2025-01-14T09:53:25Z

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

realSpok · 2025-01-20T11:29:02Z

packages/datasource-mongoose/src/utils/version-manager.ts

-  static readonly ObjectIdTypeName: 'ObjectId' | 'ObjectID' = mongoose.version.startsWith('6')
-    ? 'ObjectID'
-    : 'ObjectId';
+  static readonly ObjectIdTypeName = dynamicSchema.paths.objectId.instance;


that seems cleaner ! :)

realSpok

✅ PR title
✅ PR linked to the clickup task
✅ The PR tackle one subject only
✅ Destination branch
✅ Code review
- ✅ Use pure functions when possible
- ✅ Performance concerns
- ✅ Security concerns
- ✅ Check that nothing introduces a breaking change, including the types
✅ Automatic tests
- ✅ Unit tests
- ✅ Integration tests
✅ Manual tests
- ✅ Test the functionality
- ⤬ Test error cases

codeclimate · 2025-01-22T14:52:46Z

Code Climate has analyzed commit b412ee3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2%.

View more on Code Climate.

arnaud-moncel · 2025-01-22T15:32:29Z

🚀

# @forestadmin/datasource-mongo [1.4.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-22) ### Features * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d)) ### Dependencies * **@forestadmin/datasource-mongoose:** upgraded to 1.9.0

# [1.13.0](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.13.0) (2025-01-22) ### Features * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

# [1.9.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-22) ### Features * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

forest-bot · 2025-01-22T15:42:59Z

🎉 This PR is included in version 1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.12.18](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-22) ### Features * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

forest-bot · 2025-01-22T15:43:05Z

🎉 This PR is included in version 1.13.0 🎉

The release is available on [email protected]

Your semantic-release bot 📦🚀

forest-bot · 2025-01-22T15:43:11Z

🎉 This PR is included in version 1.9.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-22T15:43:15Z

🎉 This PR is included in version 1.12.18 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.58.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-23) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

# [1.61.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-23) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

## [1.1.47](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-23) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

## [1.5.12](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-23) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

## [1.4.15](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-23) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

## [1.1.21](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-23) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

## [1.4.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-23) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

forest-bot · 2025-01-23T10:21:15Z

🎉 This PR is included in version 1.58.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-23T10:21:30Z

🎉 This PR is included in version 1.61.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-23T10:21:39Z

🎉 This PR is included in version 1.1.47 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-23T10:21:48Z

🎉 This PR is included in version 1.5.12 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-23T10:21:57Z

🎉 This PR is included in version 1.4.15 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-23T10:22:06Z

🎉 This PR is included in version 1.1.21 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-23T10:22:15Z

🎉 This PR is included in version 1.4.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.11.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-28) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) * do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769)) * **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243)) * **validator:** allow null value for Equal operator ([#1250](#1250)) ([5d4cf3e](5d4cf3e)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

## [1.16.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-28) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) * do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769)) * **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243)) * **validator:** allow null value for Equal operator ([#1250](#1250)) ([5d4cf3e](5d4cf3e)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

## [1.47.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-28) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) * do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769)) * **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243)) * **validator:** allow null value for Equal operator ([#1250](#1250)) ([5d4cf3e](5d4cf3e)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

## [1.36.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-28) ### Bug Fixes * **datasource mongo:** remove useless version manager ([#1244](#1244)) ([fbb6698](fbb6698)) * do not override view default sorting ordrer ([#1245](#1245)) ([8e27769](8e27769)) * **lazy join:** do not remove foreignkey when they are asking ([#1246](#1246)) ([621b243](621b243)) * **validator:** allow null value for Equal operator ([#1250](#1250)) ([5d4cf3e](5d4cf3e)) ### Features * add lazy join decorator ([#1240](#1240)) ([1b6b248](1b6b248)) * support for mongoose v8 ([#1241](#1241)) ([ae0164d](ae0164d))

Dogan AY added 7 commits January 14, 2025 10:50

feat: test support for mongoose v8

e707cf6

fix: tests with v8

f378a44

fix: ci

927adfe

fix: use mongoose version without type errors

2c35524

feat: use same mongoose version across agent nodejs

87395d2

fix: ci

0c6c54b

fix: revert unecessary changes

319208b

realSpok reviewed Jan 20, 2025

View reviewed changes

realSpok changed the title ~~feat: test support for mongoose v8~~ feat: support for mongoose v8 Jan 20, 2025

realSpok approved these changes Jan 20, 2025

View reviewed changes

DayTF mentioned this pull request Jan 21, 2025

Mongoose v8 not supported #1237

Open

Dogan AY added 4 commits January 22, 2025 14:54

feat: define version manager the same way

8303c0a

revert: unneeded change

303e57d

fix: more things

2a24af8

fix: ci

b412ee3

DayTF merged commit ae0164d into main Jan 22, 2025
22 checks passed

DayTF deleted the feat/mongoose-v8 branch January 22, 2025 15:35

forest-bot added the released label Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support for mongoose v8 #1241

feat: support for mongoose v8 #1241

DayTF commented Jan 14, 2025

realSpok Jan 20, 2025

realSpok left a comment

codeclimate bot commented Jan 22, 2025

arnaud-moncel commented Jan 22, 2025

forest-bot commented Jan 22, 2025

forest-bot commented Jan 22, 2025

forest-bot commented Jan 22, 2025

forest-bot commented Jan 22, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

feat: support for mongoose v8 #1241

feat: support for mongoose v8 #1241

Conversation

DayTF commented Jan 14, 2025

Definition of Done

General

Security

realSpok Jan 20, 2025

Choose a reason for hiding this comment

realSpok left a comment

Choose a reason for hiding this comment

codeclimate bot commented Jan 22, 2025

arnaud-moncel commented Jan 22, 2025

forest-bot commented Jan 22, 2025

forest-bot commented Jan 22, 2025

forest-bot commented Jan 22, 2025

forest-bot commented Jan 22, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025

forest-bot commented Jan 23, 2025