Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permissions): properly check permissions when dissociating or deleting related resources #125

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

matthv
Copy link
Member

@matthv matthv commented Oct 9, 2024

…eting related resources

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@matthv matthv requested review from nicolasalexandre9 and jbarreau and removed request for nicolasalexandre9 October 9, 2024 15:00
@matthv matthv changed the title fix(permissions): properly check permissions when dissociating or del… fix(permissions): properly check permissions when dissociating or deleting related resources Oct 11, 2024
@matthv matthv force-pushed the fix/bad_permission_checking_on_delete_related branch from 170e4bb to 253bd5a Compare October 11, 2024 13:00
Copy link

codeclimate bot commented Oct 11, 2024

Code Climate has analyzed commit 253bd5a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 92.3%.

View more on Code Climate.

@matthv matthv merged commit 740c6f4 into main Oct 11, 2024
7 checks passed
forest-bot added a commit that referenced this pull request Oct 11, 2024
## [1.15.1](v1.15.0...v1.15.1) (2024-10-11)

### Bug Fixes

* **permissions:** properly check permissions when dissociating or deleting related resources ([#125](#125)) ([740c6f4](740c6f4))
@forest-bot
Copy link
Member

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matthv matthv deleted the fix/bad_permission_checking_on_delete_related branch October 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants