fix(schema-polling): improve polling #237

slimee · 2025-12-11T15:45:33Z

PR qui fais que le build de datasource RPC n'appelle pas get schema directement.
C'est le polling qui est utilisé dès le départ pour fetch

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

…ing logic

… fetch and current schema tracking

- Disable Naming/PredicateMethod cop for start() method (false positive) - Remove redundant begin block in fetch_initial_schema_sync - Use single quotes for static strings - Extract etag_info variable to fix line length violation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

qltysh · 2025-12-11T16:31:00Z

Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.06%.

Modified Files with Diff Coverage (2)

File	% Diff	Uncovered Line #s
...n_datasource_rpc/lib/forest_admin_datasource_rpc/datasource.rb	100.0%
...lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb	92.2%	91-93, 113-118
Total	93.8%

🤖 Increase coverage with AI coding...

In the `perf/improve-schema-polling` branch, add test coverage for this new code:

- `packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb` -- Lines 91-93 and 113-118

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb

Co-authored-by: dogan.ay <[email protected]>

## Changes ### Merge conflicts resolved - Integrated introspection fallback feature from main (PR #238) - Preserved schema polling improvements from this branch ### Schema polling enhancements - SchemaPollingClient now computes ETag locally using same algorithm as RPC slave (SHA1) - Added previous_schema parameter to initialize() for better startup resilience - ETag is computed from schema content instead of relying on server response - Ensures consistent ETag comparison between master and slave ### Cleanup - Removed obsolete SSE cleanup hooks (setup_cleanup_hooks method) - Polling thread cleanup is automatic, no need for manual signal handlers ### Integration with introspection feature - SchemaPollingClient receives provided_introspection as previous_schema - Falls back to introspection if RPC slave is unreachable at startup - Maintains schema polling for live updates once slave becomes available 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

qltysh · 2025-12-12T09:41:32Z

2 new issues

Tool	Category	Rule	Count
qlty	Structure	Function with many parameters (count = 5): initialize	1
qlty	Structure	Function with high complexity (count = 5): fetch_initial_schema_sync	1

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

- Fix RuboCop Style/RedundantAssignment offense - Return datasource directly instead of assigning then returning

- Add 'require digest' at the top of schema_polling_client.rb - Remove inline requires from compute_etag method - Fixes initialization issues when digest is not yet loaded

…andling

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

…g for RPC datasource

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

…n and error handling

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

…mpleted comment

…l sync completion

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

…trap context errors

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

qltysh · 2025-12-15T14:46:05Z

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

+      MAX_POLLING_INTERVAL = 3600

-      def initialize(uri, auth_secret, options = {}, &on_schema_change)
+      def initialize(uri, auth_secret, options = {}, introspection_schema = nil, &on_schema_change)


Function with many parameters (count = 5): initialize [qlty:function-parameters]

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

qltysh · 2025-12-16T08:46:01Z

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb

+        @introspection_schema = nil
+      rescue Faraday::ConnectionFailed, Faraday::TimeoutError,
+             ForestAdminAgent::Http::Exceptions::AuthenticationOpenIdClient, StandardError => e
+        handle_initial_fetch_error(e)


Function with high complexity (count = 5): fetch_initial_schema_sync [qlty:function-complexity]

slimee and others added 4 commits December 11, 2025 16:43

feat(schema-polling): implement initial schema fetch and improve poll…

e83e465

…ing logic

feat(schema-polling): enhance schema polling with initial synchronous…

109cd32

… fetch and current schema tracking

fix(schema polling): improve initial polling behavior and logging

faa6fb3

slimee changed the title ~~feat(schema-polling): improve polling~~ fix(schema-polling): improve polling Dec 11, 2025

DayTF reviewed Dec 12, 2025

View reviewed changes

packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb Outdated Show resolved Hide resolved

slimee and others added 2 commits December 12, 2025 10:16

chore: fix typo

0af3bc6

Co-authored-by: dogan.ay <[email protected]>

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

slimee added 4 commits December 12, 2025 10:43

fix(rpc): remove redundant assignment in build method

132044b

- Fix RuboCop Style/RedundantAssignment offense - Return datasource directly instead of assigning then returning

fix(schema-polling): move digest require to top of file

6215deb

- Add 'require digest' at the top of schema_polling_client.rb - Remove inline requires from compute_etag method - Fixes initialization issues when digest is not yet loaded

chore: trigger CI rerun

503b38a

fix(schema): update polling interval option naming and improve ETag h…

408e75e

…andling

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

fix(schema-polling): improve initial sync handling and error reportin…

e31919d

…g for RPC datasource

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

refactor(schema polling): update log levels for schema sync completio…

b65252d

…n and error handling

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

slimee added 2 commits December 12, 2025 15:36

fix(schema_polling): remove unnecessary whitespace in initial_sync_co…

d54d4d2

…mpleted comment

fix(schema polling): trigger schema update callback only after initia…

36e2b48

…l sync completion

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

feat(datasource): add graceful shutdown hook for schema polling cleanup

63c3956

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

refactor(schema_polling): improve thread stopping mechanism to avoid …

ac06b19

…trap context errors

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

fix(schema_polling): ensure graceful shutdown of polling thread

9115481

qltysh bot reviewed Dec 12, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

fix: call only one time the get schema at start

ab74679

qltysh bot reviewed Dec 15, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

arnaud-moncel force-pushed the perf/improve-schema-polling branch from 405ecb7 to 8d0da82 Compare December 15, 2025 13:43

qltysh bot reviewed Dec 15, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

fix: call with introspection

4053f38

arnaud-moncel force-pushed the perf/improve-schema-polling branch from 8d0da82 to 4053f38 Compare December 15, 2025 13:59

qltysh bot reviewed Dec 15, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Outdated Show resolved Hide resolved

qltysh bot reviewed Dec 15, 2025

View reviewed changes

chore: improve polling

f62484a

arnaud-moncel force-pushed the perf/improve-schema-polling branch from a3213ac to f62484a Compare December 15, 2025 15:02

qltysh bot reviewed Dec 15, 2025

View reviewed changes

...s/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb Show resolved Hide resolved

fix: polling start

af3e857

qltysh bot reviewed Dec 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(schema-polling): improve polling #237

fix(schema-polling): improve polling #237

slimee commented Dec 11, 2025 •

edited

Loading

Uh oh!

qltysh bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

qltysh bot commented Dec 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot Dec 15, 2025

Uh oh!

Uh oh!

Uh oh!

qltysh bot Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(schema-polling): improve polling #237

Are you sure you want to change the base?

fix(schema-polling): improve polling #237

Conversation

slimee commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Definition of Done

General

Security

Uh oh!

qltysh bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

qltysh bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2 new issues

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

qltysh bot Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

slimee commented Dec 11, 2025 •

edited

Loading

qltysh bot commented Dec 11, 2025 •

edited

Loading

qltysh bot commented Dec 12, 2025 •

edited

Loading