Skip to content

Fixed Text File Editor losing unsaved changes when rotating screen #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 3 commits into from
May 21, 2025
Merged

Fixed Text File Editor losing unsaved changes when rotating screen #111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac38cf9
Fixed Text File Editor loosing unsaved changes when rotating screen
Burgerpower01 Jul 12, 2024
6d4635c
Merge branch 'master' into master
naveensingh May 20, 2025
4308ded
style: replace state variable with constant
naveensingh May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions app/src/main/kotlin/org/fossify/filemanager/activities/ReadTextActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class ReadTextActivity : SimpleActivity() {
companion object {
private const val SELECT_SAVE_FILE_INTENT = 1
private const val SELECT_SAVE_FILE_AND_EXIT_INTENT = 2
private const val KEY_UNSAVED_TEXT = "KEY_UNSAVED_TEXT"
}

private val binding by viewBinding(ActivityReadTextBinding::inflate)
Expand Down Expand Up @@ -85,7 +86,7 @@ class ReadTextActivity : SimpleActivity() {

binding.readTextView.onGlobalLayout {
ensureBackgroundThread {
checkIntent(uri)
checkIntent(uri, savedInstanceState)
}
}

Expand All @@ -97,6 +98,13 @@ class ReadTextActivity : SimpleActivity() {
setupToolbar(binding.readTextToolbar, NavigationIcon.Arrow)
}

override fun onSaveInstanceState(outState: Bundle) {
super.onSaveInstanceState(outState)
if (originalText != binding.readTextView.text.toString()) {
outState.putString(KEY_UNSAVED_TEXT, binding.readTextView.text.toString())
}
}

override fun onActivityResult(requestCode: Int, resultCode: Int, resultData: Intent?) {
super.onActivityResult(requestCode, resultCode, resultData)
if (requestCode == SELECT_SAVE_FILE_INTENT && resultCode == Activity.RESULT_OK && resultData != null && resultData.data != null) {
Expand Down Expand Up @@ -241,7 +249,7 @@ class ReadTextActivity : SimpleActivity() {
}
}

private fun checkIntent(uri: Uri) {
private fun checkIntent(uri: Uri, savedInstanceState: Bundle?) {
originalText = if (uri.scheme == "file") {
filePath = uri.path!!
val file = File(filePath)
Expand Down Expand Up @@ -270,7 +278,13 @@ class ReadTextActivity : SimpleActivity() {
}

runOnUiThread {
binding.readTextView.setText(originalText)
var textToSet = originalText

if (savedInstanceState != null) {
textToSet = savedInstanceState.getString(KEY_UNSAVED_TEXT, originalText)
}

binding.readTextView.setText(textToSet)
if (originalText.isNotEmpty()) {
hideKeyboard()
} else {
Expand Down